Page MenuHomePhabricator
Differential D7948

rpc/net: decode the services flags in a new entry
ClosedPublic
Actions

Authored by PiRK on Oct 16 2020, 09:02.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCe5b0e658a2f3: rpc/net: decode the services flags in a new entry
Summary

This adds human readable network services to the output of getpeerinfo and getnetworkinfo

Backport of Core PR16787

Test Plan

Run src/bitcoin-cli getnetworkinfo and check the localservicesnames field.

More tests coming in PR16850

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 16 2020, 09:02
Owners added a reviewer: Restricted Owners Package.Oct 16 2020, 09:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 16 2020, 09:02
PiRK requested review of this revision.Oct 16 2020, 09:02
teamcity edited the summary of this revision. (Show Details)Oct 16 2020, 09:02
PiRK updated this revision to Diff 24710.Oct 16 2020, 09:05

improve release notes by specifying the name of the new field

Harbormaster completed remote builds in B13446: Diff 24709.Oct 16 2020, 09:13
Harbormaster completed remote builds in B13447: Diff 24710.Oct 16 2020, 09:20
PiRK added a child revision: D7949: tests: add a test for the 'servicesnames' RPC field.Oct 16 2020, 09:28
Fabien accepted this revision.Oct 16 2020, 12:37
This revision is now accepted and ready to land.Oct 16 2020, 12:37
Closed by commit rABCe5b0e658a2f3: rpc/net: decode the services flags in a new entry (authored by darosior <darosior@gmail.com>, committed by PiRK). · Explain WhyOct 16 2020, 14:26
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCe5b0e658a2f3: rpc/net: decode the services flags in a new entry.

Revision Contents
Changeset List

PathSize
doc/
2 lines
src/
rpc/
18 lines
7 lines
28 lines

Diff 24722

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/rpc/util.h

Loading...
View Options

src/rpc/util.cpp

Loading...