Differential D7971

[secp256k1] Enable endomorphism by default
ClosedPublic
Actions

Authored by deadalnix on Oct 17 2020, 14:21.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc6dbc176ffa9: [secp256k1] Enable endomorphism by default

Summary

The patent on this optimisation expired, so it can be enabled by default now.

Also fix a warning about possibly uninitialized variable.

Test Plan

ninja all check-all

Ran the extended test suite under ubsan and did run IBD + kept node runnign under ubsan for testnet and mainnet over night.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 17 2020, 14:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 17 2020, 14:21

deadalnix requested review of this revision.Oct 17 2020, 14:21

deadalnix edited the summary of this revision. (Show Details)Oct 17 2020, 14:30

Harbormaster completed remote builds in B13474: Diff 24757.Oct 17 2020, 14:30

Fabien accepted this revision.Oct 17 2020, 18:13

This revision is now accepted and ready to land.Oct 17 2020, 18:13

Closed by commit rABCc6dbc176ffa9: [secp256k1] Enable endomorphism by default (authored by deadalnix). · Explain WhyOct 17 2020, 18:16

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCc6dbc176ffa9: [secp256k1] Enable endomorphism by default.

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

CMakeLists.txt

2 lines

src/

modules/

schnorr/

schnorr_impl.h

2 lines

Diff 24761

View Options

src/secp256k1/CMakeLists.txt