[Doc] Add documentation for the new whitelist permissions
ClosedPublic
Actions

Authored by PiRK on Oct 19 2020, 07:52.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCfdedc9312f38: [Doc] Add documentation for the new whitelist permissions

Summary

Backport of Core PR16629

Depends on D7976

Test Plan

ninja && src/bitcoind -help

Diff Detail

Repository

rABC Bitcoin ABC

Branch

backport-pr16555

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13483
Build 26997: Build Diff	lint-circular-dependencies · build-diff · build-without-wallet · build-clang · build-clang-tidy
Build 26996: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 19 2020, 07:52

Owners added a reviewer: Restricted Owners Package.Oct 19 2020, 07:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 19 2020, 07:52

PiRK requested review of this revision.Oct 19 2020, 07:52

teamcity edited the summary of this revision. (Show Details)Oct 19 2020, 07:52

PiRK edited the summary of this revision. (Show Details)Oct 19 2020, 07:52

PiRK added a parent revision: D7976: [doc] mention whitelist is inbound, and applies to blocksonly.

PiRK edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B13482: Diff 24772.Oct 19 2020, 07:55

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Snippet of first build failure:

[313/484] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[314/484] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[315/484] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[316/484] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[317/484] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[318/484] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[319/484] Building CXX object src/CMakeFiles/script.dir/script/standard.cpp.o
[320/484] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[321/484] Building CXX object src/CMakeFiles/script.dir/script/sign.cpp.o
[322/484] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[323/484] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[324/484] Linking C static library src/secp256k1/libsecp256k1.a
[325/484] Linking C executable src/secp256k1/ecmult-bench
[326/484] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[327/484] Linking C executable src/secp256k1/internal-bench
[328/484] Linking C executable src/secp256k1/sign-bench
[329/484] Linking C executable src/secp256k1/verify-bench
[330/484] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[331/484] Linking C executable src/secp256k1/recover-bench
[332/484] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[333/484] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[334/484] Linking CXX static library src/libscript.a
[335/484] Linking CXX static library src/libcommon.a
[336/484] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[337/484] Linking CXX static library src/libbitcoinconsensus.a
[338/484] Linking CXX executable src/bitcoin-cli
[339/484] Linking CXX shared library src/libbitcoinconsensus.so.0.22.5
[340/484] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[341/484] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[342/484] Linking CXX executable src/bitcoin-tx
[343/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[344/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[345/484] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[346/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[347/484] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[348/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[349/484] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[350/484] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[351/484] Building CXX object src/seeder/CMakeFiles/seeder.dir/dns.cpp.o
[352/484] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[353/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[354/484] Building CXX object src/seeder/CMakeFiles/seeder.dir/bitcoin.cpp.o
[355/484] Building CXX object src/seeder/CMakeFiles/seeder.dir/db.cpp.o
[356/484] Linking CXX static library src/seeder/libseeder.a
[357/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[358/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/psbtwallet.cpp.o
[359/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[360/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[361/484] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[362/484] Linking CXX executable src/seeder/bitcoin-seeder
[363/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[364/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[365/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[366/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[367/484] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[368/484] Linking CXX static library src/wallet/libwallet.a
[369/484] Linking CXX static library src/wallet/libwallet-tool.a
[370/484] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Snippet of first build failure:

[314/486] Linking C executable src/secp256k1/internal-bench
[315/486] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[316/486] Building CXX object src/CMakeFiles/util.dir/util/validation.cpp.o
[317/486] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/arith_uint256.cpp.o
[318/486] Building CXX object src/CMakeFiles/util.dir/rpc/request.cpp.o
[319/486] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[320/486] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/uint256.cpp.o
[321/486] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[322/486] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[323/486] Building CXX object src/CMakeFiles/util.dir/blockdb.cpp.o
[324/486] Building CXX object src/CMakeFiles/util.dir/util/error.cpp.o
[325/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[326/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[327/486] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[328/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[329/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/psbtwallet.cpp.o
[330/486] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[331/486] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[332/486] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[333/486] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[334/486] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[335/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[336/486] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqabstractnotifier.cpp.o
[337/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[338/486] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqpublishnotifier.cpp.o
[339/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[340/486] Building CXX object src/CMakeFiles/util.dir/util/system.cpp.o
[341/486] Linking CXX static library src/libutil.a
[342/486] Linking CXX static library src/libscript.a
[343/486] Linking CXX static library src/libcommon.a
[344/486] Linking CXX static library src/librpcclient.a
[345/486] Linking CXX executable src/bitcoin-cli
[346/486] Linking CXX static library src/libbitcoinconsensus.a
[347/486] Linking CXX shared library src/libbitcoinconsensus.so.0.22.5
[348/486] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[349/486] Linking CXX executable src/bitcoin-tx
[350/486] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[351/486] Building CXX object src/seeder/CMakeFiles/seeder.dir/bitcoin.cpp.o
[352/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[353/486] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[354/486] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[355/486] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqnotificationinterface.cpp.o
[356/486] Building CXX object src/seeder/CMakeFiles/seeder.dir/dns.cpp.o
[357/486] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[358/486] Building CXX object src/seeder/CMakeFiles/seeder.dir/db.cpp.o
[359/486] Linking CXX static library src/seeder/libseeder.a
[360/486] Linking CXX executable src/seeder/bitcoin-seeder
[361/486] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqrpc.cpp.o
[362/486] Linking CXX static library src/zmq/libzmq.a
[363/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[364/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[365/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[366/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[367/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[368/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[369/486] Linking CXX static library src/wallet/libwallet.a
[370/486] Linking CXX static library src/wallet/libwallet-tool.a
[371/486] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Snippet of first build failure:

[316/435] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[317/435] Building CXX object src/CMakeFiles/server.dir/txdb.cpp.o
[318/435] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[319/435] Building CXX object src/CMakeFiles/server.dir/ui_interface.cpp.o
[320/435] Building CXX object src/CMakeFiles/server.dir/validationinterface.cpp.o
[321/435] Building CXX object src/CMakeFiles/server.dir/versionbits.cpp.o
[322/435] Building CXX object src/CMakeFiles/server.dir/dummywallet.cpp.o
[323/435] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[324/435] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[325/435] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[326/435] Building CXX object src/seeder/CMakeFiles/seeder.dir/dns.cpp.o
[327/435] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[328/435] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[329/435] Building CXX object src/seeder/CMakeFiles/seeder.dir/bitcoin.cpp.o
[330/435] Building CXX object src/seeder/CMakeFiles/seeder.dir/db.cpp.o
[331/435] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[332/435] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[333/435] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[334/435] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[335/435] Linking C static library src/secp256k1/libsecp256k1.a
[336/435] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[337/435] Linking C executable src/secp256k1/ecmult-bench
[338/435] Linking C executable src/secp256k1/recover-bench
[339/435] Linking C executable src/secp256k1/sign-bench
[340/435] Linking C executable src/secp256k1/internal-bench
[341/435] Linking C executable src/secp256k1/verify-bench
[342/435] Linking CXX static library src/libcommon.a
[343/435] Linking CXX static library src/libscript.a
[344/435] Linking CXX static library src/libbitcoinconsensus.a
[345/435] Linking CXX static library src/seeder/libseeder.a
[346/435] Linking CXX shared library src/libbitcoinconsensus.so.0.22.5
[347/435] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[348/435] Linking CXX executable src/bitcoin-cli
[349/435] Linking CXX executable src/seeder/bitcoin-seeder
[350/435] Linking CXX executable src/bitcoin-tx
[351/435] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
FAILED: src/CMakeFiles/server.dir/init.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wshadow -Wredundant-decls -Wformat-security -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++14 -MD -MT src/CMakeFiles/server.dir/init.cpp.o -MF src/CMakeFiles/server.dir/init.cpp.o.d -o src/CMakeFiles/server.dir/init.cpp.o -c ../../src/init.cpp
../../src/init.cpp: In function ‘void SetupServerArgs()’:
../../src/init.cpp:718:1: error: version control conflict marker in file
 <<<<<<< HEAD
 ^~~~~~~
../../src/init.cpp:718:3: error: expected primary-expression before ‘<<’ token
 <<<<<<< HEAD
   ^~
../../src/init.cpp:718:5: error: expected primary-expression before ‘<<’ token
 <<<<<<< HEAD
     ^~
../../src/init.cpp:718:7: error: expected primary-expression before ‘<’ token
 <<<<<<< HEAD
       ^
../../src/init.cpp:718:9: error: ‘HEAD’ was not declared in this scope
 <<<<<<< HEAD
         ^~~~
../../src/init.cpp:718:9: note: suggested alternative: ‘EADV’
 <<<<<<< HEAD
         ^~~~
         EADV
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

[321/486] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[322/486] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[323/486] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[324/486] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[325/486] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[326/486] Linking C static library src/secp256k1/libsecp256k1.a
[327/486] Linking CXX static library src/libscript.a
[328/486] Linking CXX static library src/libcommon.a
[329/486] Linking CXX static library src/libbitcoinconsensus.a
[330/486] Linking CXX shared library src/libbitcoinconsensus.so.0.22.5
[331/486] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[332/486] Linking C executable src/secp256k1/ecmult-bench
[333/486] Linking C executable src/secp256k1/internal-bench
[334/486] Linking C executable src/secp256k1/sign-bench
[335/486] Linking C executable src/secp256k1/verify-bench
[336/486] Linking C executable src/secp256k1/recover-bench
[337/486] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[338/486] Installing component secp256k1
-- Install configuration: "RelWithDebInfo"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[339/486] Linking CXX executable src/bitcoin-cli
[340/486] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[341/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[342/486] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[343/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[344/486] Linking CXX executable src/bitcoin-tx
[345/486] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[346/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[347/486] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[348/486] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[349/486] Linking CXX static library src/zmq/libzmq.a
[350/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[351/486] Building CXX object src/seeder/CMakeFiles/seeder.dir/bitcoin.cpp.o
[352/486] Building CXX object src/seeder/CMakeFiles/seeder.dir/dns.cpp.o
[353/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[354/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[355/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/psbtwallet.cpp.o
[356/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[357/486] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[358/486] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[359/486] Building CXX object src/seeder/CMakeFiles/seeder.dir/db.cpp.o
[360/486] Linking CXX static library src/seeder/libseeder.a
[361/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[362/486] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[363/486] Linking CXX executable src/seeder/bitcoin-seeder
[364/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[365/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[366/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[367/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[368/486] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[369/486] Linking CXX static library src/wallet/libwallet.a
[370/486] Linking CXX static library src/wallet/libwallet-tool.a
[371/486] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

remove "<<<<<<< HEAD"

Harbormaster completed remote builds in B13483: Diff 24773.Oct 19 2020, 08:23

Fabien accepted this revision.Oct 19 2020, 09:48

This revision is now accepted and ready to land.Oct 19 2020, 09:48

Closed by commit rABCfdedc9312f38: [Doc] Add documentation for the new whitelist permissions (authored by nicolas.dorier <nicolas.dorier@gmail.com>, committed by PiRK). · Explain WhyOct 19 2020, 11:43

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCfdedc9312f38: [Doc] Add documentation for the new whitelist permissions.