Page MenuHomePhabricator

[backport#16865] test: add some unit tests for merkle.cpp
ClosedPublic

Authored by PiRK on Oct 21 2020, 08:25.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC48baf4ea7c59: [backport#16865] test: add some unit tests for merkle.cpp
Summary

following situations are covered:

  • empty block
  • one Tx
  • Merkle root of a block with odd Txs should not change with repeating

last one

  • Merkle root is computed with combining Merkle root of left subtree and right subtree

Signed-off-by: soroosh-sdi <soroosh.sardari@gmail.com>

Backport of Core PR16865

Test Plan

ninja && ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Oct 21 2020, 08:25
PiRK requested review of this revision.Oct 21 2020, 08:25

Tail of the build log:

----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[136/411] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/versionbits_tests.cpp.o
[137/411] Linking CXX executable src/pow/test/test-pow
[138/411] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/db_tests.cpp.o
[139/411] avalanche: testing proof_tests
[140/411] Running utility command for check-avalanche-proof_tests
[141/411] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/write_name_tests.cpp.o
[142/411] pow: testing eda_tests
[143/411] avalanche: testing peermanager_tests
[144/411] Running utility command for check-pow-eda_tests
[145/411] Running utility command for check-avalanche-peermanager_tests
[146/411] pow: testing daa_tests
[147/411] Running utility command for check-pow-daa_tests
[148/411] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/init_tests.cpp.o
[149/411] avalanche: testing processor_tests
[150/411] Running utility command for check-avalanche-processor_tests
[151/411] Running avalanche test suite
PASSED: avalanche test suite
[152/411] Automatic MOC for target test_bitcoin-qt
[153/411] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_crypto_tests.cpp.o
[154/411] Linking CXX executable src/seeder/test/test-seeder
[155/411] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/ismine_tests.cpp.o
[156/411] seeder: testing parse_name_tests
[157/411] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/coinselector_tests.cpp.o
[158/411] Running utility command for check-seeder-parse_name_tests
[159/411] seeder: testing p2p_messaging_tests
[160/411] Running utility command for check-seeder-p2p_messaging_tests
[161/411] seeder: testing write_name_tests
[162/411] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/psbt_wallet_tests.cpp.o
[163/411] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/util.cpp.o
[164/411] Running utility command for check-seeder-write_name_tests
[165/411] Running seeder test suite
PASSED: seeder test suite
[166/411] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/walletdb_tests.cpp.o
[167/411] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_tests.cpp.o
[168/411] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/bitcoinaddressvalidatortests.cpp.o
[169/411] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/uritests.cpp.o
[170/411] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/compattests.cpp.o
[171/411] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_bitcoin-qt_autogen/mocs_compilation.cpp.o
[172/411] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/guiutiltests.cpp.o
[173/411] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o
[174/411] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o
[175/411] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o
[176/411] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/apptests.cpp.o
[177/411] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[178/411] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[179/411] pow: testing aserti32d_tests
[180/411] Running utility command for check-pow-aserti32d_tests
[181/411] Running pow test suite
PASSED: pow test suite
[182/411] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[183/411] Linking CXX executable src/qt/test/test_bitcoin-qt
[184/411] bitcoin-qt: testing test_bitcoin-qt
[185/411] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
This revision is now accepted and ready to land.Oct 21 2020, 10:33