Differential D802

Modify QR code to fit cashaddr
ClosedPublic
Actions

Authored by dagurval on Dec 13 2017, 12:44.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING87b604444cc5: Modify QR code to fit cashaddr
rABC87b604444cc5: Modify QR code to fit cashaddr

Summary

This bumps the size of the QR code and also decreases the font size when
using cashaddr.

The encoded address is displayed as text in the QR code image. This allows
for the longer cashaddr to fit in the image.

Test Plan

Create a request using QT client on mainnet. Tested on Ubuntu.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dagurval created this revision.Dec 13 2017, 12:44

Harbormaster completed remote builds in B1362: Diff 2109.Dec 13 2017, 12:44

Screenshot from 2017-12-13 13-27-41.png (627×487 px, 47 KB)

dagurval added a reviewer: Restricted Project.Dec 13 2017, 13:39

deadalnix accepted this revision.Dec 13 2017, 15:38

This revision is now accepted and ready to land.Dec 13 2017, 15:38

Closed by commit rABC87b604444cc5: Modify QR code to fit cashaddr (authored by dagurval). · Explain WhyDec 13 2017, 18:41

This revision was automatically updated to reflect the committed changes.

This revision has failed testing.

PiRK mentioned this in D7794: GUI: Move QRImageWidget to its own file-pair.Oct 7 2020, 07:25

Revision Contents
Changeset List

Path

Size

src/

qt/

guiconstants.h

2 lines

receiverequestdialog.cpp

4 lines

Diff 2115

View Options

src/qt/guiconstants.h