Differential D8058

[BUILDBOT] Remove unecessary imports of the phabricator library
ClosedPublic
Actions

Authored by Fabien on Oct 22 2020, 15:30.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC57e85e779508: [BUILDBOT] Remove unecessary imports of the phabricator library

Summary

Only the phabricator wrapper should import the phabricator library.

Test Plan

pytest

Diff Detail

Repository

rABC Bitcoin ABC

Branch

buildbot_phabricator_wrapper_results

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13600
Build 27231: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 27230: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 22 2020, 15:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2020, 15:30

Fabien requested review of this revision.Oct 22 2020, 15:30

Harbormaster completed remote builds in B13600: Diff 24953.Oct 22 2020, 15:55

jasonbcox accepted this revision.Oct 22 2020, 17:32

This revision is now accepted and ready to land.Oct 22 2020, 17:32

Closed by commit rABC57e85e779508: [BUILDBOT] Remove unecessary imports of the phabricator library (authored by Fabien). · Explain WhyOct 22 2020, 20:06

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC57e85e779508: [BUILDBOT] Remove unecessary imports of the phabricator library.

Revision Contents
Changeset List

Path

Size

contrib/

buildbot/

test/

mocks/

phabricator.py

8 lines

test_phabricator.py

6 lines

Diff 24953

View Options

contrib/buildbot/test/mocks/phabricator.py