Page MenuHomePhabricator

[gui] send dialog: split on_sendButton_clicked
ClosedPublic

Authored by deadalnix on Oct 23 2020, 01:59.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCfaa53213a723: [gui] send dialog: split on_sendButton_clicked
Summary

This commit does not change behavior.

Backport of Core PR17509 part [1/6] : https://github.com/bitcoin/bitcoin/pull/17509/commits/6ab3aad9a51cc5e97a8e2ae7dbd5082272163c30

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Failed tests logs:

====== Bitcoin ABC functional tests: rpc_bind.py ======

------- Stdout: -------
2020-10-23T02:01:12.246000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201023_020108/rpc_bind_103
2020-10-23T02:01:12.291000Z TestFramework (INFO): Using interface 172.17.0.2 for testing
2020-10-23T02:01:12.291000Z TestFramework (INFO): Bind test for []
2020-10-23T02:01:12.969000Z TestFramework (INFO): Bind test for []
2020-10-23T02:01:13.530000Z TestFramework (INFO): Bind test for ['127.0.0.1']
2020-10-23T02:01:13.997000Z TestFramework (INFO): Bind test for ['127.0.0.1:32171']
2020-10-23T02:01:14.490000Z TestFramework (INFO): Bind test for ['127.0.0.1:32171', '127.0.0.1:32172']
2020-10-23T02:01:14.760000Z TestFramework (ERROR): Unexpected exception caught during testing
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/rpc_bind.py", line 127, in run_test
    [('127.0.0.1', 32171), ('127.0.0.1', 32172)])
  File "/work/test/functional/rpc_bind.py", line 52, in run_bind_test
    assert_equal(set(get_bind_addrs(pid)), set(expected))
  File "/work/test/functional/test_framework/netutil.py", line 87, in get_bind_addrs
    inodes = get_socket_inodes(pid)
  File "/work/test/functional/test_framework/netutil.py", line 37, in get_socket_inodes
    target = os.readlink(os.path.join(base, item))
FileNotFoundError: [Errno 2] No such file or directory: '/proc/4929/fd/17'
2020-10-23T02:01:14.811000Z TestFramework (INFO): Stopping nodes
2020-10-23T02:01:15.012000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201023_020108/rpc_bind_103
2020-10-23T02:01:15.013000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201023_020108/rpc_bind_103/test_framework.log
2020-10-23T02:01:15.013000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201023_020108/rpc_bind_103' to consolidate all logs

Each failure log is accessible here:
Bitcoin ABC functional tests: rpc_bind.py

This revision is now accepted and ready to land.Oct 23 2020, 06:19
This revision was landed with ongoing or failed builds.Oct 23 2020, 10:49
This revision was automatically updated to reflect the committed changes.