Paths

Table of Contentst

Differential D8075

[RPC] Fix casing in getblockchaininfo to be inline with the rest of the response
ClosedPublic
Actions

Authored by PiRK on Oct 23 2020, 11:52.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC761a61277750: [RPC] Fix casing in getblockchaininfo to be inline with the rest of the response

Summary

The original PR changed the case of a parameter return by getblockchaininfo: startTime -> start_time
Luckily in our codebase it is only the documentation that was wrong, so this does not break compatibility. The parameter was reintroduced in Bitcoin ABC earlier this year while restoring BIP9 RPC support (D5135)

Backport of Core PR16817

Test Plan

bitcoin-cli help getblockchaininfo

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 23 2020, 11:52

Owners added a reviewer: Restricted Owners Package.Oct 23 2020, 11:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 23 2020, 11:52

PiRK requested review of this revision.Oct 23 2020, 11:52

teamcity edited the summary of this revision. (Show Details)Oct 23 2020, 11:53

deadalnix accepted this revision.Oct 23 2020, 12:03

This revision is now accepted and ready to land.Oct 23 2020, 12:03

Harbormaster completed remote builds in B13624: Diff 25007.Oct 23 2020, 12:04

Closed by commit rABC761a61277750: [RPC] Fix casing in getblockchaininfo to be inline with the rest of the response (authored by Dan Gershony <dan.gershony@gmail.com>, committed by PiRK). · Explain WhyOct 23 2020, 12:31

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC761a61277750: [RPC] Fix casing in getblockchaininfo to be inline with the rest of the response.

Revision Contents
Changeset List

Path

Size

src/

rpc/

2 lines

Diff 25012

src/rpc/blockchain.cpp

Loading...