Differential D8094

Refactor rawtransaction's SignTransaction into generic SignTransaction function
ClosedPublic
Actions

Authored by deadalnix on Oct 24 2020, 16:45.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCdabfedaea058: Refactor rawtransaction's SignTransaction into generic SignTransaction function

Summary

Backport of Core PR18115 part [1/9] : https://github.com/bitcoin/bitcoin/pull/18115/commits/2c52b59d0a44a86d94fee4e437978d822862c542

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr18115-1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13646
Build 27318: Build Diff	lint-circular-dependencies · build-diff · build-without-wallet · build-clang-tidy · build-clang · build-debug
Build 27317: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 24 2020, 16:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 24 2020, 16:45

deadalnix requested review of this revision.Oct 24 2020, 16:45

teamcity edited the summary of this revision. (Show Details)Oct 24 2020, 16:45

deadalnix added a child revision: D8095: Add SignTransaction function to ScriptPubKeyMan and LegacyScriptPubKeyMan.Oct 24 2020, 16:56

Harbormaster completed remote builds in B13646: Diff 25046.Oct 24 2020, 16:57

PiRK accepted this revision.Oct 24 2020, 18:03

This revision is now accepted and ready to land.Oct 24 2020, 18:03

Closed by commit rABCdabfedaea058: Refactor rawtransaction's SignTransaction into generic SignTransaction function (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyOct 24 2020, 18:57

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCdabfedaea058: Refactor rawtransaction's SignTransaction into generic SignTransaction function.

Revision Contents
Changeset List

Path

Size

src/

rpc/

rawtransaction_util.h

5 lines

rawtransaction_util.cpp

75 lines

script/

sign.h

7 lines

sign.cpp

54 lines

Diff 25046

View Options

src/rpc/rawtransaction_util.h

View Options

src/rpc/rawtransaction_util.cpp

View Options

src/script/sign.h

View Options

Refactor rawtransaction's SignTransaction into generic SignTransaction functionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25046

src/rpc/rawtransaction_util.h

src/rpc/rawtransaction_util.cpp

src/script/sign.h

src/script/sign.cpp

Refactor rawtransaction's SignTransaction into generic SignTransaction function
ClosedPublic
Actions

Revision Contents
Changeset List