Differential D8096

Implement CWallet::SignTransaction using ScriptPubKeyMan::SignTransaction
ClosedPublic
Actions

Authored by deadalnix on Oct 24 2020, 17:02.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCdd2c6cebcda0: Implement CWallet::SignTransaction using ScriptPubKeyMan::SignTransaction

Summary

Backport of Core PR18115 part [3/9] : https://github.com/bitcoin/bitcoin/pull/18115/commits/f37de927442d3f024926a66c436d59e391c8696a

Depends on D8095

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr18115-3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13648
Build 27322: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang · build-debug · build-clang-tidy
Build 27321: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 24 2020, 17:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 24 2020, 17:02

deadalnix requested review of this revision.Oct 24 2020, 17:02

teamcity edited the summary of this revision. (Show Details)Oct 24 2020, 17:02

Harbormaster completed remote builds in B13648: Diff 25048.Oct 24 2020, 17:10

PiRK accepted this revision.Oct 24 2020, 18:22

This revision is now accepted and ready to land.Oct 24 2020, 18:22

Closed by commit rABCdd2c6cebcda0: Implement CWallet::SignTransaction using ScriptPubKeyMan::SignTransaction (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyOct 24 2020, 19:00

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCdd2c6cebcda0: Implement CWallet::SignTransaction using ScriptPubKeyMan::SignTransaction.

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.h

13 lines

wallet.cpp

96 lines

Diff 25048

View Options

src/wallet/wallet.h