Differential D8103

Clear any input_errors for an input after it is signed
ClosedPublic
Actions

Authored by deadalnix on Oct 24 2020, 22:23.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC7f2483ac9415: Clear any input_errors for an input after it is signed

Summary

Make sure that there are no errors set for an input after it is signed.
This is useful for when there are multiple ScriptPubKeyMans. Some may
fail to sign, but one may be able to sign, and after it does, we don't
want there to be any more errors there.

Backport of Core PR18115 part [9/9] : https://github.com/bitcoin/bitcoin/pull/18115/commits/d2774c09cfcc6c5c967d40bb094eabc8c0bdb6bf

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 24 2020, 22:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 24 2020, 22:23

deadalnix requested review of this revision.Oct 24 2020, 22:23

teamcity edited the summary of this revision. (Show Details)Oct 24 2020, 22:24

Harbormaster completed remote builds in B13655: Diff 25059.Oct 24 2020, 22:32

majcosta accepted this revision.Oct 25 2020, 00:19

This revision is now accepted and ready to land.Oct 25 2020, 00:19

Closed by commit rABC7f2483ac9415: Clear any input_errors for an input after it is signed (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyOct 25 2020, 00:35

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC7f2483ac9415: Clear any input_errors for an input after it is signed.

Revision Contents
Changeset List

Path

Size

src/

script/

3 lines

Diff 25066

src/script/sign.cpp

Loading...