Page MenuHomePhabricator
Differential D8106

add stdin helpers for password input support
ClosedPublic
Actions

Authored by PiRK on Oct 25 2020, 07:54.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC4289dc7952fc: add stdin helpers for password input support
Summary

This helpers will be used for no-echo input when typing passwords in a terminal.

This is a backport of Core PR13716 [1/3]
Commit https://github.com/bitcoin/bitcoin/pull/13716/commits/0da503e9475fea5644168544668581796bf66334

Test Plan

cmake .. -GNinja && ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 25 2020, 07:54
Owners added a reviewer: Restricted Owners Package.Oct 25 2020, 07:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 25 2020, 07:54
PiRK requested review of this revision.Oct 25 2020, 07:54
teamcity edited the summary of this revision. (Show Details)Oct 25 2020, 07:54
PiRK mentioned this in D8107: cli: add -stdinwalletpassphrase for (slightly more) secure CLI.Oct 25 2020, 08:01
Harbormaster completed remote builds in B13659: Diff 25069.Oct 25 2020, 08:07
deadalnix requested changes to this revision.Oct 25 2020, 15:26
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/CMakeLists.txt
624 ↗(On Diff #25069)

Edit to match cmake style.

This revision now requires changes to proceed.Oct 25 2020, 15:26
PiRK updated this revision to Diff 25082.Oct 25 2020, 15:45

put add_library's closing parentesis on a newline followed by a blank line

Harbormaster completed remote builds in B13668: Diff 25082.Oct 25 2020, 16:08
deadalnix accepted this revision.Oct 25 2020, 17:00
This revision is now accepted and ready to land.Oct 25 2020, 17:00
Closed by commit rABC4289dc7952fc: add stdin helpers for password input support (authored by Karl-Johan Alm <kalle.alm@gmail.com>, committed by PiRK). · Explain WhyOct 25 2020, 19:34
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC4289dc7952fc: add stdin helpers for password input support.
PiRK mentioned this in rABC7f275f57df19: cli: add -stdinwalletpassphrase for (slightly more) secure CLI.Oct 25 2020, 20:07

Revision Contents
Changeset List

PathSize
src/
6 lines
compat/
18 lines
73 lines

Diff 25088

View Options

src/CMakeLists.txt

Loading...
View Options

src/compat/stdin.h

Loading...
View Options

src/compat/stdin.cpp

Loading...