Page MenuHomePhabricator
Differential D8107

cli: add -stdinwalletpassphrase for (slightly more) secure CLI
ClosedPublic
Actions

Authored by PiRK on Oct 25 2020, 07:58.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC7f275f57df19: cli: add -stdinwalletpassphrase for (slightly more) secure CLI
Summary

This PR

  • adds -stdinwalletpassphrase for use with walletpasshprase(change)
  • adds no-echo for passwords (-stdinrpcpass and above)

This is a backport of Core PR13716 [2/3]
Commit: https://github.com/bitcoin/bitcoin/pull/13716/commits/7f11fba2e3c7b1e00ffb98504cdcfc2ded9c09cf
Depends D8106

Test Plan
src/bitcoin-cli -help
src/bitcoin-cli -stdinrpcpass getnetworkinfo
src/bitcoin-cli -stdinrpcpass -stdinwalletpassphrase walletpassphrase

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 25 2020, 07:58
Owners added a reviewer: Restricted Owners Package.Oct 25 2020, 07:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 25 2020, 07:58
PiRK requested review of this revision.Oct 25 2020, 07:58
teamcity edited the summary of this revision. (Show Details)Oct 25 2020, 07:58
PiRK added a child revision: D8108: add newline after -stdin*.Oct 25 2020, 08:01
PiRK edited the summary of this revision. (Show Details)Oct 25 2020, 08:01
Harbormaster completed remote builds in B13660: Diff 25070.Oct 25 2020, 08:14
deadalnix requested changes to this revision.Oct 25 2020, 15:24
deadalnix added a subscriber: deadalnix.

Add a link to the commit.

This revision now requires changes to proceed.Oct 25 2020, 15:24
PiRK requested review of this revision.Oct 25 2020, 15:45
PiRK edited the summary of this revision. (Show Details)
deadalnix accepted this revision.Oct 25 2020, 17:01
This revision is now accepted and ready to land.Oct 25 2020, 17:01
Closed by commit rABC7f275f57df19: cli: add -stdinwalletpassphrase for (slightly more) secure CLI (authored by Karl-Johan Alm <kalle.alm@gmail.com>, committed by PiRK). · Explain WhyOct 25 2020, 20:07
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC7f275f57df19: cli: add -stdinwalletpassphrase for (slightly more) secure CLI.

Revision Contents
Changeset List

PathSize
src/
35 lines

Diff 25090

View Options

src/bitcoin-cli.cpp

Loading...