Page MenuHomePhabricator
Differential D8122

Show addresses for "SendToSelf" transactions
ClosedPublic
Actions

Authored by PiRK on Oct 26 2020, 10:53.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC16f28961a94f: Show addresses for "SendToSelf" transactions
Summary

With this change, the transactions tab of bitcoin-qt now shows the address for "Payment to yourself" transactions.

This is a backport of Core PR15098

Test Plan

ninja && src/qt/bitcoin-qt
Create a receive address on the Receive tab and send some BCH to it on the Send tab.
Verify that the Transactions tab now show the involved addresses.

Diff Detail

Event Timeline

PiRK created this revision.Oct 26 2020, 10:53
Owners added a reviewer: Restricted Owners Package.Oct 26 2020, 10:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 26 2020, 10:53
PiRK requested review of this revision.Oct 26 2020, 10:53
teamcity edited the summary of this revision. (Show Details)Oct 26 2020, 10:53
Harbormaster completed remote builds in B13678: Diff 25106.Oct 26 2020, 11:01
deadalnix requested changes to this revision.Oct 26 2020, 13:08
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/qt/transactionrecord.cpp
102

Why not encode destination? This will break for user who chose to not use cashaddr.

This revision now requires changes to proceed.Oct 26 2020, 13:08
PiRK requested review of this revision.Oct 26 2020, 20:43
PiRK added inline comments.
src/qt/transactionrecord.cpp
102

CashAddr is already used everywhere in bitcoin-qt.

$ grep -r EncodeDestination src/qt | wc -l
0
$ grep -r EncodeCashAddr src/qt | wc -l
14
deadalnix accepted this revision.Oct 26 2020, 22:59
This revision is now accepted and ready to land.Oct 26 2020, 22:59
Closed by commit rABC16f28961a94f: Show addresses for "SendToSelf" transactions (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyOct 27 2020, 18:31
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC16f28961a94f: Show addresses for "SendToSelf" transactions.

Revision Contents
Changeset List

Diff 25106

View Options

src/qt/transactionrecord.cpp

Loading...
View Options

src/qt/transactiontablemodel.cpp

Loading...