Page MenuHomePhabricator

[backport#14975] qt: Refactoring with QString::toNSString()
ClosedPublic

Authored by majcosta on Oct 26 2020, 19:28.

Details

Summary

4d454dcb6 Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (#14725).

The behavior of `MacNotificationHandler::showNotification()` has not been changed.

cc: @jonasschnelli

Backport of Core PR14975

Test Plan
ninja all check check-functional

I don't have macOS to run the suite sadly

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable