HomePhabricator

[backport#14975] qt: Refactoring with QString::toNSString()

Description

[backport#14975] qt: Refactoring with QString::toNSString()

Summary:
4d454dcb6 Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (#14725).

The behavior of `MacNotificationHandler::showNotification()` has not been changed.

cc: @jonasschnelli

Backport of Core PR14975

Test Plan:

ninja all check check-functional

I don't have macOS to run the suite sadly

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D8132

Details

Provenance
Jonas Schnelli <dev@jonasschnelli.ch>Authored on Oct 26 2020, 21:59
majcostaCommitted on Oct 26 2020, 21:59
abc-botPushed on Oct 26 2020, 22:03
Reviewer
Restricted Project
Differential Revision
D8132: [backport#14975] qt: Refactoring with QString::toNSString()
Parents
rABC82ded1d00472: [backport#14375] qt: Correct misleading "overridden options" label
Branches
Unknown
Tags
Unknown