Page MenuHomePhabricator
Differential D8147

GUI: Restore RPC Console to non-wallet tray icon menu
AbandonedPublic
Actions

Authored by PiRK on Oct 28 2020, 08:23.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

PR description:

PR14383 moved the debug window's menu position, to make it conditional on wallet mode. The rationale given was to match the behaviour of the 'Help' menu.

PR14573 replaced the 'Help' menu's conditional debug window with an unconditional list of items in the new 'Window' menu.

This PR reverts the no-longer-applicable part of #14383, putting the debug window back on the tray menu unconditionally, and in the position it previously had.

This is a backport of Core PR15023
Depends on D8146

Test Plan

ninja && src/qt/bitcoin-qt -disablewallet

Diff Detail

Event Timeline

PiRK created this revision.Oct 28 2020, 08:23
Owners added a reviewer: Restricted Owners Package.Oct 28 2020, 08:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 28 2020, 08:23
PiRK requested review of this revision.Oct 28 2020, 08:23
teamcity edited the summary of this revision. (Show Details)Oct 28 2020, 08:23
PiRK edited the summary of this revision. (Show Details)Oct 28 2020, 08:24
PiRK added a parent revision: D8146: Clean systray icon menu for -disablewallet mode.
Harbormaster completed remote builds in B13706: Diff 25166.Oct 28 2020, 08:29
teamcity added a comment.Oct 28 2020, 08:29
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 28 2020, 08:31
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 28 2020, 08:32
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Fabien requested changes to this revision.Oct 28 2020, 13:36
Fabien mentioned this in D8146: Clean systray icon menu for -disablewallet mode.
Fabien added a subscriber: Fabien.

See D8146

This revision now requires changes to proceed.Oct 28 2020, 13:36
PiRK abandoned this revision.Oct 28 2020, 14:32

squashed into D8146

Revision Contents
Changeset List

PathSize
src/
qt/
2 lines

Diff 25166

View Options

src/qt/bitcoingui.cpp

Loading...