Page MenuHomePhabricator

test: Fix combine_logs.py for windows
ClosedPublic

Authored by PiRK on Oct 28 2020, 09:33.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCee0e7ccc93a2: test: Fix combine_logs.py for windows
Summary

The regex used to find the chain name in debug.log path did not work on Windows due to the different path separator.
This uses pathlib to make sure the path used for the regex search is as_posix()

This is a backport of Core PR16973

Test Plan

I tested that it still works on my linux machine, with the same test as D7796

Intentionaly modify a functional test to make it fail (assert False), then run:

../test/functional/feature_bip68_sequence.py --configfile=./test/config.ini
../test/functional/combine_logs.py -c

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Oct 28 2020, 09:33
PiRK requested review of this revision.Oct 28 2020, 09:33
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

revert intentional test failure used for testing the script (should have not been part of the commit)

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
This revision is now accepted and ready to land.Oct 28 2020, 13:45
This revision was automatically updated to reflect the committed changes.