Page MenuHomePhabricator
Differential D7796

[test] combine_logs: append node stderr and stdout if it exists
ClosedPublic
Actions

Authored by PiRK on Oct 7 2020, 09:06.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCa96f22d8d82e: [test] combine_logs: append node stderr and stdout if it exists
Summary

Description of issue that motivated this PR:

Currently the stdout of bitcoinds in functional tests is written to a file in self.datadir of the node. It is only read/examined after the node is shut down. To aid debugging it should (also?) be passed to the logger for visibility and timestamps.

Backport of Core PR15841
Depends on D7795

Test Plan

Intentionaly modify a functional test to make it fail, then check that node stdout is now part of the combined logs.

ninja
../test/functional/feature_bip68_sequence.py --configfile=./test/config.ini
../test/functional/combine_logs.py -c

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 7 2020, 09:06
Owners added a reviewer: Restricted Owners Package.Oct 7 2020, 09:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2020, 09:06
PiRK requested review of this revision.Oct 7 2020, 09:06
teamcity edited the summary of this revision. (Show Details)Oct 7 2020, 09:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

PiRK edited the summary of this revision. (Show Details)Oct 7 2020, 09:07
PiRK added a parent revision: D7795: tests: have combine_logs default to most recent test dir.
PiRK mentioned this in D7780: [test] combine_logs: append node stderr and stdout if it exists.
Harbormaster completed remote builds in B13233: Diff 24331.Oct 7 2020, 09:18
Fabien accepted this revision.Oct 7 2020, 15:55
This revision is now accepted and ready to land.Oct 7 2020, 15:55
Closed by commit rABCa96f22d8d82e: [test] combine_logs: append node stderr and stdout if it exists (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyOct 7 2020, 16:38
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCa96f22d8d82e: [test] combine_logs: append node stderr and stdout if it exists.
PiRK mentioned this in D8150: test: Fix combine_logs.py for windows.Oct 28 2020, 09:33
PiRK mentioned this in rABCee0e7ccc93a2: test: Fix combine_logs.py for windows.Oct 28 2020, 15:07

Revision Contents
Changeset List

PathSize
test/
functional/
91 lines

Diff 24349

View Options

test/functional/combine_logs.py

Loading...