Differential D8153

Add bounds checks before base58 decoding
ClosedPublic
Actions

Authored by Fabien on Oct 28 2020, 11:04.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCcf70ca7accbc: Add bounds checks before base58 decoding

Summary

Backport of core PR17511.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR17511

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13714
Build 27448: Build Diff	build-without-wallet · lint-circular-dependencies · build-diff · build-debug · build-clang-tidy · build-clang
Build 27447: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 28 2020, 11:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 28 2020, 11:04

Fabien requested review of this revision.Oct 28 2020, 11:04

teamcity edited the summary of this revision. (Show Details)Oct 28 2020, 11:04

Harbormaster completed remote builds in B13714: Diff 25175.Oct 28 2020, 11:17

Fabien added a child revision: D8154: util: Don't allow Base58 decoding of non-Base58 strings. Add Base58 tests..Oct 28 2020, 13:07

deadalnix accepted this revision.Oct 28 2020, 13:44

This revision is now accepted and ready to land.Oct 28 2020, 13:44

Closed by commit rABCcf70ca7accbc: Add bounds checks before base58 decoding (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by Fabien). · Explain WhyOct 28 2020, 13:53

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCcf70ca7accbc: Add bounds checks before base58 decoding.

Revision Contents
Changeset List

Path

Size

src/

base58.h

10 lines

base58.cpp

32 lines

bench/

base58.cpp

2 lines

key_io.cpp

8 lines

test/

base58_tests.cpp

28 lines

Diff 25175

View Options

src/base58.h

View Options

src/base58.cpp

View Options

src/bench/base58.cpp

View Options

src/key_io.cpp

View Options

Add bounds checks before base58 decodingClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25175

src/base58.h

src/base58.cpp

src/bench/base58.cpp

src/key_io.cpp

src/test/base58_tests.cpp

Add bounds checks before base58 decoding
ClosedPublic
Actions

Revision Contents
Changeset List