Page MenuHomePhabricator
Differential D8161

gui: don't disable the sync overlay when wallet is disabled
ClosedPublic
Actions

Authored by PiRK on Oct 28 2020, 19:57.

Details

Reviewers
majcosta
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC5a179f986cc8: gui: don't disable the sync overlay when wallet is disabled
Summary

When running with -disablewallet the sync modal is now available by clicking on the progress bar or syncing icon.

This is a backport of Core PR15084

Test Plan

ninja && src/qt/bitcoin-qt -disablewallet

Click on the progress bar or syncing icon to show the sync overlay dialog.

Diff Detail

Event Timeline

PiRK created this revision.Oct 28 2020, 19:57
Owners added a reviewer: Restricted Owners Package.Oct 28 2020, 19:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 28 2020, 19:57
PiRK requested review of this revision.Oct 28 2020, 19:57
teamcity edited the summary of this revision. (Show Details)Oct 28 2020, 19:57
Harbormaster completed remote builds in B13723: Diff 25196.Oct 28 2020, 20:04
majcosta requested changes to this revision.Oct 28 2020, 20:11
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/qt/modaloverlay.cpp
30

Bitcoin ABC*

This revision now requires changes to proceed.Oct 28 2020, 20:11
PiRK updated this revision to Diff 25198.Oct 28 2020, 20:33

fix message (Core -> ABC)

Harbormaster completed remote builds in B13725: Diff 25198.Oct 28 2020, 20:48
majcosta accepted this revision.Oct 28 2020, 22:23
This revision is now accepted and ready to land.Oct 28 2020, 22:23
Closed by commit rABC5a179f986cc8: gui: don't disable the sync overlay when wallet is disabled (authored by Ben Carman <benthecarman@live.com>, committed by PiRK). · Explain WhyOct 29 2020, 10:49
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC5a179f986cc8: gui: don't disable the sync overlay when wallet is disabled.

Revision Contents
Changeset List

PathSize
src/
qt/
10 lines
2 lines
9 lines

Diff 25196

View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/modaloverlay.h

Loading...
View Options

src/qt/modaloverlay.cpp

Loading...