Page MenuHomePhabricator
Differential D8167

[backport#11448] [gui] reset addrProxy/addrSeparateProxyTor if colon char missing
AbandonedPublic
Actions

Authored by majcosta on Oct 29 2020, 03:02.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

ce2418f [gui] reset addrProxy/addrSeparateProxyTor if colon char missing (Cristian Mircea Messel)

Pull request description:

If addrProxy or addrSeparateProxyTor do not have a colon in the string
somewhere in the QSettings storage, then attempting to open the options
dialog will cause the entire program to crash.

Fixes #11209

Backport of Core PR11448

Test Plan
ninja all check check-functional

Diff Detail

Event Timeline

majcosta created this revision.Oct 29 2020, 03:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 29 2020, 03:02
majcosta requested review of this revision.Oct 29 2020, 03:02
teamcity edited the summary of this revision. (Show Details)Oct 29 2020, 03:02
Harbormaster completed remote builds in B13730: Diff 25209.Oct 29 2020, 03:25
Fabien requested changes to this revision.Oct 29 2020, 07:48
Fabien added a subscriber: Fabien.

This is reverted by PR11809 which was ported in D2680

This revision now requires changes to proceed.Oct 29 2020, 07:48
majcosta abandoned this revision.Oct 29 2020, 15:55

oh cool this is a skip then. abandoning

Revision Contents
Changeset List

PathSize
src/
qt/
6 lines

Diff 25209

View Options

src/qt/optionsmodel.cpp

Loading...