Page MenuHomePhabricator
Differential D8193

gui: Make polling in ClientModel asynchronous
ClosedPublic
Actions

Authored by PiRK on Oct 30 2020, 13:57.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC3bfb5fc3f8c5: gui: Make polling in ClientModel asynchronous
Summary

After #14193 ClientModel::updateTimer can take some time, as such the GUI hangs, like #17112.

Fixes this by polling in a background thread and updating the GUI asynchronously.

This is a backport of Core PR17135 and Core PR17427

The second PR fixes a bug introduced by the first (ClientModel::mempoolSizeChanged() signal has unregistered parameter type size_t)

Test Plan

ninja && ninja check && src/qt/bitcoin-qt

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 30 2020, 13:57
Owners added a reviewer: Restricted Owners Package.Oct 30 2020, 13:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 30 2020, 13:57
PiRK requested review of this revision.Oct 30 2020, 13:58
teamcity edited the summary of this revision. (Show Details)Oct 30 2020, 13:58
Harbormaster completed remote builds in B13766: Diff 25270.Oct 30 2020, 14:14
Fabien requested changes to this revision.Oct 30 2020, 16:37
Fabien added a subscriber: Fabien.

You need PR17427 as well

This revision now requires changes to proceed.Oct 30 2020, 16:37
PiRK updated this revision to Diff 25280.Oct 30 2020, 17:15

squash with PR17427

PiRK edited the summary of this revision. (Show Details)Oct 30 2020, 17:16
PiRK edited the test plan for this revision. (Show Details)
PiRK edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B13775: Diff 25280.Oct 30 2020, 17:29
Fabien requested changes to this revision.Oct 30 2020, 21:08
Fabien added inline comments.
src/qt/bitcoin.cpp
544 ↗(On Diff #25280)

You're missing a change from PR17427 here

This revision now requires changes to proceed.Oct 30 2020, 21:08
PiRK updated this revision to Diff 25304.Oct 31 2020, 07:12

complete comment line 544, and ordering of lines (size_t before
std::function<void(), with a blank line in between)

Harbormaster completed remote builds in B13788: Diff 25304.Oct 31 2020, 07:24
Fabien accepted this revision.Oct 31 2020, 10:24
This revision is now accepted and ready to land.Oct 31 2020, 10:24
Closed by commit rABC3bfb5fc3f8c5: gui: Make polling in ClientModel asynchronous (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by PiRK). · Explain WhyOct 31 2020, 16:47
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC3bfb5fc3f8c5: gui: Make polling in ClientModel asynchronous.

Revision Contents
Changeset List

PathSize
src/
qt/
12 lines
4 lines
34 lines

Diff 25306

View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/clientmodel.h

Loading...
View Options

src/qt/clientmodel.cpp

Loading...