Page MenuHomePhabricator

Avoid unused call to GuessVerificationProgress in NotifyHeaderTip
ClosedPublic

Authored by PiRK on Oct 30 2020, 17:07.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC7e43e1683d9b: Avoid unused call to GuessVerificationProgress in NotifyHeaderTip
Summary

GuessVerificationProgress for a header (not a block) is always 0 because the number of txs in the block can not be determined from the header alone. Anyway, this result was never used, so we can optimize this call by hardcoding 0.

This is the next commit in a series of changes toward removing nChainTx (see #14863, #13875)

This is a backport of Core PR17250

Test Plan

ninja && ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable