Page MenuHomePhabricator
Differential D8252

[tools] add PoissonNextSend method that returns mockable time
ClosedPublic
Actions

Authored by PiRK on Nov 3 2020, 14:18.

Details

Reviewers
majcosta
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC73791ff552e6: [tools] add PoissonNextSend method that returns mockable time
Summary

Introduce a Poisson helper method that wraps the existing method to return std::chrono::duration type, which is mockable.

This is a backport of Core PR17243

Test Plan

ninja && ninja check

Diff Detail

Event Timeline

PiRK created this revision.Nov 3 2020, 14:18
Owners added a reviewer: Restricted Owners Package.Nov 3 2020, 14:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 3 2020, 14:18
PiRK requested review of this revision.Nov 3 2020, 14:18
teamcity edited the summary of this revision. (Show Details)Nov 3 2020, 14:18
Harbormaster completed remote builds in B13835: Diff 25392.Nov 3 2020, 14:30
majcosta accepted this revision.Nov 3 2020, 19:55
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/net_processing.cpp
4343

I'd keep the newline after this, makes a clean break from a time block and rest of the code, reads better imho

This revision is now accepted and ready to land.Nov 3 2020, 19:55
PiRK updated this revision to Diff 25404.Nov 4 2020, 06:52

address feedback: added blank line like in the original PR

Harbormaster completed remote builds in B13840: Diff 25404.Nov 4 2020, 07:05
Closed by commit rABC73791ff552e6: [tools] add PoissonNextSend method that returns mockable time (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by PiRK). · Explain WhyNov 4 2020, 07:47
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC73791ff552e6: [tools] add PoissonNextSend method that returns mockable time.

Revision Contents
Changeset List

PathSize
src/
11 lines
12 lines
test/
16 lines

Diff 25392

View Options

src/net.h

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/test/net_tests.cpp

Loading...