Page MenuHomePhabricator
Differential D8286

test: add unit test for non-standard txs with wrong nVersion
ClosedPublic
Actions

Authored by PiRK on Nov 5 2020, 14:08.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCea176cecdd4b: test: add unit test for non-standard txs with wrong nVersion
Summary

Takes care of one of the missing cases of #17394: nVersion must be within the allowed range.

This is a backport of Core PR17555

Test Plan

ninja && ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 5 2020, 14:08
Owners added a reviewer: Restricted Owners Package.Nov 5 2020, 14:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 5 2020, 14:09
PiRK requested review of this revision.Nov 5 2020, 14:09
teamcity edited the summary of this revision. (Show Details)Nov 5 2020, 14:09
Harbormaster completed remote builds in B13876: Diff 25462.Nov 5 2020, 14:19
Fabien requested changes to this revision.Nov 5 2020, 17:04
Fabien added a subscriber: Fabien.

The PR number is wrong

This revision now requires changes to proceed.Nov 5 2020, 17:04
PiRK requested review of this revision.Nov 5 2020, 17:20
PiRK edited the summary of this revision. (Show Details)

PR# fixed

Fabien accepted this revision.Nov 5 2020, 17:35
This revision is now accepted and ready to land.Nov 5 2020, 17:35
Closed by commit rABCea176cecdd4b: test: add unit test for non-standard txs with wrong nVersion (authored by Dominik Spicher <dominik.spicher@inacta.ch>, committed by PiRK). · Explain WhyNov 5 2020, 19:32
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCea176cecdd4b: test: add unit test for non-standard txs with wrong nVersion.

Revision Contents
Changeset List

PathSize
src/
test/
23 lines

Diff 25484

View Options

src/test/transaction_tests.cpp

Loading...