Page MenuHomePhabricator

gui: disable File->CreateWallet during startup
ClosedPublic

Authored by PiRK on Nov 6 2020, 09:12.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCcf625f6480b6: gui: disable File->CreateWallet during startup
Summary

Same as PR16118. Early calls to Create Wallet will crash bitcoin-qt.

This PR disables menus actions at startup and enables them again later
in BitcoinGUI::setWalletController.
I could not test that the menu is disabled, because on my Ubuntu machine
I don't have access to these menus until after the startup rescan is finished.
AFAIK, these menus are visible on Windows (through the systray icon) or Mac as
soon as the program is started, while the program is still showing the startup screen.

This is a backport of Core PR17695

Test Plan

Build and run bitcoin-qt, and make sure the menu still works after startup rescan is completed.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable