HomePhabricator

gui: disable File->CreateWallet during startup

Description

gui: disable File->CreateWallet during startup

Summary:

Same as PR16118. Early calls to Create Wallet will crash bitcoin-qt.

This PR disables menus actions at startup and enables them again later
in BitcoinGUI::setWalletController.
I could not test that the menu is disabled, because on my Ubuntu machine
I don't have access to these menus until after the startup rescan is finished.
AFAIK, these menus are visible on Windows (through the systray icon) or Mac as
soon as the program is started, while the program is still showing the startup screen.

This is a backport of Core PR17695

Test Plan: Build and run bitcoin-qt, and make sure the menu still works after startup rescan is completed.

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8302

Details

Provenance
fanquake <fanquake@gmail.com>Authored on Nov 7 2020, 17:29
PiRKCommitted on Nov 7 2020, 17:30
abc-botPushed on Nov 7 2020, 17:35
Reviewer
Restricted Project
Differential Revision
D8302: gui: disable File->CreateWallet during startup
Parents
rABC542557427be0: ui: disable 3rd-party tx-urls when wallet disabled
Branches
Unknown
Tags
Unknown