Page MenuHomePhabricator
Differential D8337

test: Fix intermittent sync_blocks failures
ClosedPublic
Actions

Authored by Fabien on Nov 9 2020, 17:32.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCa37866bcc40a: test: Fix intermittent sync_blocks failures
Summary

Backport of core PR18873.

The version check is not ported as we don't expect user to run the tests
against an older version of bitcoind.

Test Plan
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 9 2020, 17:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 9 2020, 17:32
Fabien requested review of this revision.Nov 9 2020, 17:32
teamcity edited the summary of this revision. (Show Details)Nov 9 2020, 17:32
Harbormaster completed remote builds in B13946: Diff 25588.Nov 9 2020, 17:45
deadalnix requested changes to this revision.Nov 9 2020, 17:59
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
test/functional/test_framework/test_node.py
323 ↗(On Diff #25588)

Why was the version check removed?

This revision now requires changes to proceed.Nov 9 2020, 17:59
Fabien requested review of this revision.Nov 9 2020, 19:07

The version check is not ported as we don't expect user to run the tests against an older version of bitcoind.

The version check can make sense for core because they do backport changes to previous versions, but this is not our case. I removed it because I don't think there is a use case for it.

deadalnix accepted this revision.Nov 10 2020, 02:45
This revision is now accepted and ready to land.Nov 10 2020, 02:45
Closed by commit rABCa37866bcc40a: test: Fix intermittent sync_blocks failures (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyNov 10 2020, 06:54
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCa37866bcc40a: test: Fix intermittent sync_blocks failures.

Revision Contents
Changeset List

PathSize
test/
functional/
9 lines
5 lines
12 lines
test_framework/
19 lines
7 lines
13 lines

Diff 25606

View Options

test/functional/feature_loadblock.py

Loading...
View Options

test/functional/feature_reindex.py

Loading...
View Options

test/functional/mempool_persist.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...
View Options

test/functional/wallet_abandonconflict.py

Loading...
View Options

test/functional/wallet_basic.py

Loading...