Page MenuHomePhabricator

test: Fix intermittent sync_blocks failures
ClosedPublic

Authored by Fabien on Nov 9 2020, 17:32.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCa37866bcc40a: test: Fix intermittent sync_blocks failures
Summary

Backport of core PR18873.

The version check is not ported as we don't expect user to run the tests
against an older version of bitcoind.

Test Plan
ninja check-functional

Event Timeline

Fabien requested review of this revision.Nov 9 2020, 17:32
deadalnix requested changes to this revision.Nov 9 2020, 17:59
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
test/functional/test_framework/test_node.py
323

Why was the version check removed?

This revision now requires changes to proceed.Nov 9 2020, 17:59
Fabien requested review of this revision.Nov 9 2020, 19:07

The version check is not ported as we don't expect user to run the tests against an older version of bitcoind.

The version check can make sense for core because they do backport changes to previous versions, but this is not our case. I removed it because I don't think there is a use case for it.

This revision is now accepted and ready to land.Nov 10 2020, 02:45