Differential D8358

tests: accept unicode characters on Windows
ClosedPublic
Actions

Authored by PiRK on Nov 10 2020, 16:42.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC6b6adaedc766: tests: accept unicode characters on Windows

Summary

This is a backport of Core PR13787

Test Plan

functional tests on windows ci

Diff Detail

Repository

rABC Bitcoin ABC

Branch

backport-pr13787

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13971
Build 27950: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 27949: arc lint + arc unit

Event Timeline

PiRK created this revision.Nov 10 2020, 16:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2020, 16:42

PiRK requested review of this revision.Nov 10 2020, 16:42

teamcity edited the summary of this revision. (Show Details)Nov 10 2020, 16:42

@bot build-win64

teamcity awarded a token.Nov 10 2020, 16:43

Change looks good.
Unfortunately the functional tests won't run on windows (at least not all and not reliably) and it's even worst on wine, so unless you have a windows machine at hand you can't really test it, and even so it's not trivial (I did it a few times).

This revision is now accepted and ready to land.Nov 10 2020, 17:00

Harbormaster completed remote builds in B13971: Diff 25634.Nov 10 2020, 17:02

Closed by commit rABC6b6adaedc766: tests: accept unicode characters on Windows (authored by Chun Kuan Lee <ken2812221@gmail.com>, committed by PiRK). · Explain WhyNov 10 2020, 17:52

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC6b6adaedc766: tests: accept unicode characters on Windows.