Replace byte editing in a raw hexadecimal transaction by a more readable element swap in a CTransaction.vout list
This is a backport of Core PR15397
Details
Details
- Reviewers
majcosta - Group Reviewers
Restricted Project - Commits
- rABC48be09690967: Remove manual byte editing in wallet_tx_clone func test
ninja && test/functional/test_runner.py wallet_txn*
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- backport-pr15397
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 13983 Build 27973: Build Diff lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang Build 27972: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Tail of the build log:
[214/415] Running utility command for check-bitcoin-random_tests [215/415] bitcoin: testing limitedmap_tests [216/415] bitcoin: testing sigcheckcount_tests [217/415] Running utility command for check-bitcoin-sigcheckcount_tests [218/415] Running utility command for check-bitcoin-limitedmap_tests [219/415] bitcoin: testing rwcollection_tests [220/415] bitcoin: testing pmt_tests [221/415] Running utility command for check-bitcoin-rwcollection_tests [222/415] bitcoin: testing flatfile_tests [223/415] bitcoin: testing sigcache_tests [224/415] Running utility command for check-bitcoin-pmt_tests [225/415] bitcoin: testing feerate_tests [226/415] Running utility command for check-bitcoin-flatfile_tests [227/415] Running utility command for check-bitcoin-sigcache_tests [228/415] bitcoin: testing txindex_tests [229/415] Running utility command for check-bitcoin-feerate_tests [230/415] bitcoin: testing dstencode_tests [231/415] Running utility command for check-bitcoin-txindex_tests [232/415] bitcoin: testing interfaces_tests [233/415] bitcoin: testing script_standard_tests [234/415] Running utility command for check-bitcoin-interfaces_tests [235/415] Running utility command for check-bitcoin-dstencode_tests [236/415] Running utility command for check-bitcoin-script_standard_tests [237/415] bitcoin: testing descriptor_tests [238/415] bitcoin: testing ismine_tests [239/415] Running utility command for check-bitcoin-descriptor_tests [240/415] Running utility command for check-bitcoin-ismine_tests [241/415] bitcoin: testing policyestimator_tests [242/415] bitcoin: testing compress_tests [243/415] bitcoin: testing rcu_tests [244/415] bitcoin: testing wallet_crypto_tests [245/415] bitcoin: testing scriptnum_tests [246/415] bitcoin: testing db_tests [247/415] bitcoin: testing skiplist_tests [248/415] bitcoin: testing sigencoding_tests [249/415] bitcoin: testing cuckoocache_tests [250/415] Running utility command for check-bitcoin-policyestimator_tests [251/415] bitcoin: testing coinselector_tests FAILED: src/test/CMakeFiles/check-bitcoin-coinselector_tests cd /work/abc-ci-builds/build-clang-tidy/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang-tidy/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang-tidy/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang-tidy/test/log/bitcoin-coinselector_tests.log /work/abc-ci-builds/build-clang-tidy/src/test/test_bitcoin --run_test=coinselector_tests --logger=HRF,test_suite:JUNIT,message,bitcoin-coinselector_tests.xml --catch_system_errors=no Running 4 test cases... Entering test module "Bitcoin ABC unit tests" ../../src/wallet/test/coinselector_tests.cpp(22): Entering test suite "coinselector_tests" ../../src/wallet/test/coinselector_tests.cpp(149): Entering test case "bnb_search_test" Segmentation fault (core dumped) [252/415] Running utility command for check-bitcoin-compress_tests [253/415] Running utility command for check-bitcoin-rcu_tests [254/415] Running utility command for check-bitcoin-wallet_crypto_tests [255/415] Running utility command for check-bitcoin-scriptnum_tests [256/415] Running utility command for check-bitcoin-skiplist_tests [257/415] Running utility command for check-bitcoin-db_tests [258/415] Running utility command for check-bitcoin-cuckoocache_tests [259/415] Running utility command for check-bitcoin-sigencoding_tests [260/415] bitcoin: testing versionbits_tests [261/415] bitcoin: testing mempool_tests [262/415] bitcoin: testing denialofservice_tests [263/415] bitcoin: testing dbwrapper_tests [264/415] bitcoin: testing checkqueue_tests ninja: build stopped: subcommand failed. Build build-clang-tidy failed with exit code 1
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.
Failed tests logs:
====== Bitcoin ABC functional tests: p2p_timeouts.py ======
------- Stdout: -------
2020-11-11T10:24:49.006000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_ _20201111_102419/p2p_timeouts_489
2020-11-11T10:24:54.342000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/work/test/functional/test_framework/test_framework.py", line 120, in main
self.run_test()
File "/work/test/functional/p2p_timeouts.py", line 89, in run_test
assert not no_verack_node.is_connected
AssertionError
2020-11-11T10:25:07.148000Z TestFramework (INFO): Stopping nodes
2020-11-11T10:25:07.249000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_ _20201111_102419/p2p_timeouts_489
2020-11-11T10:25:07.249000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_ _20201111_102419/p2p_timeouts_489/test_framework.log
2020-11-11T10:25:07.250000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_ _20201111_102419/p2p_timeouts_489' to consolidate all logsEach failure log is accessible here:
Bitcoin ABC functional tests: p2p_timeouts.py