Page MenuHomePhabricator

[backport#11558] Minimal code changes to allow msvc compilation
ClosedPublic

Authored by majcosta on Nov 12 2020, 20:59.

Details

Summary

fbf327b Minimal code changes to allow msvc compilation. (Aaron Clauson)

Pull request description:

These changes are required to allow the Bitcoin source to build with Microsoft's C++ compiler (#11562 is also required).

I looked around for a better place for the typedef of ssize_t which is in random.h. The best candidate looks like src/compat.h but I figured including that header in random.h is a bigger change than the typedef. Note that the same typedef is in at least two other places including the OpenSSL and Berkeley DB headers so some of the Bitcoin code already picks it up.

Backport of Core PR11558

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable