HomePhabricator

[backport#11558] Minimal code changes to allow msvc compilation

Description

[backport#11558] Minimal code changes to allow msvc compilation

Summary:
fbf327b Minimal code changes to allow msvc compilation. (Aaron Clauson)

Pull request description:

These changes are required to allow the Bitcoin source to build with Microsoft's C++ compiler (#11562 is also required).

I looked around for a better place for the typedef of ssize_t which is in random.h. The best candidate looks like src/compat.h but I figured including that header in random.h is a bigger change than the typedef. Note that the same typedef is in at least two other places including the OpenSSL and Berkeley DB headers so some of the Bitcoin code already picks it up.

Backport of Core PR11558

Test Plan:

ninja all check check-functional

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D8379

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Dec 13 2017, 12:32
majcostaCommitted on Nov 13 2020, 03:50
majcostaPushed on Nov 13 2020, 03:50
Reviewer
Restricted Project
Differential Revision
D8379: [backport#11558] Minimal code changes to allow msvc compilation
Parents
rABC1a229a0ad622: Relayout doccomments in descriptor.h
Branches
Unknown
Tags
Unknown