Page MenuHomePhabricator

net: Log to net category for exceptions in ProcessMessages
ClosedPublic

Authored by PiRK on Nov 13 2020, 09:59.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC39bcc7aeb41b: net: Log to net category for exceptions in ProcessMessages
Summary

Remove the forest of special exceptions, and simply log a short
message to the NET logging category when an exception happens during
packet processing. It is not good to panick end users with errors
that any peer can generate (let alone writing to stderr).

Add missing typeinfo includes
The use of typeid() for logging exception types requires this include
according to https://en.cppreference.com/w/cpp/language/typeid.

This is a backport of Core PR17762

Test Plan

ninja && ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable