HomePhabricator

net: Log to net category for exceptions in ProcessMessages

Description

net: Log to net category for exceptions in ProcessMessages

Summary:

Remove the forest of special exceptions, and simply log a short
message to the NET logging category when an exception happens during
packet processing. It is not good to panick end users with errors
that any peer can generate (let alone writing to stderr).

Add missing typeinfo includes
The use of typeid() for logging exception types requires this include
according to https://en.cppreference.com/w/cpp/language/typeid.

This is a backport of Core PR17762

Test Plan: ninja && ninja check

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8390

Details

Provenance
Wladimir J. van der Laan <laanwj@protonmail.com>Authored on Dec 17 2019, 14:43
PiRKCommitted on Nov 13 2020, 14:53
PiRKPushed on Nov 13 2020, 14:53
Reviewer
Restricted Project
Differential Revision
D8390: net: Log to net category for exceptions in ProcessMessages
Parents
rABCec5a073bd022: Cache parent xpub inside of BIP32PubkeyProvider
Branches
Unknown
Tags
Unknown