Backport of Core PR16528 [21/43] : https://github.com/bitcoin/bitcoin/pull/16528/commits/58c7651821b0eeff0a99dc61d78d2e9e07986580
Depends on D8417
Differential D8419
Implement TopUp in DescriptorScriptPubKeyMan deadalnix on Nov 15 2020, 01:26. Authored by
Details
Backport of Core PR16528 [21/43] : https://github.com/bitcoin/bitcoin/pull/16528/commits/58c7651821b0eeff0a99dc61d78d2e9e07986580 Depends on D8417 ninja all check-all
Diff Detail
Event TimelineComment Actions Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Tail of the build log: [319/489] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o [320/489] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o [321/489] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o [322/489] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o [323/489] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o [324/489] Building CXX object src/CMakeFiles/script.dir/script/interpreter.cpp.o [325/489] Linking C static library src/secp256k1/libsecp256k1.a [326/489] Linking C executable src/secp256k1/internal-bench [327/489] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o [328/489] Linking C executable src/secp256k1/sign-bench [329/489] Linking C executable src/secp256k1/verify-bench [330/489] Linking C executable src/secp256k1/recover-bench [331/489] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o [332/489] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o [333/489] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o [334/489] Building CXX object src/CMakeFiles/script.dir/script/standard.cpp.o [335/489] Building CXX object src/CMakeFiles/script.dir/script/sign.cpp.o [336/489] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o [337/489] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o [338/489] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o [339/489] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o [340/489] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o [341/489] Linking C executable src/secp256k1/ecmult-bench [342/489] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o [343/489] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o [344/489] Linking CXX static library src/libscript.a [345/489] Linking CXX static library src/libcommon.a [346/489] Linking CXX executable src/bitcoin-cli [347/489] Linking CXX static library src/libbitcoinconsensus.a [348/489] Linking CXX shared library src/libbitcoinconsensus.so.0.22.7 [349/489] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so [350/489] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o [351/489] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o [352/489] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o [353/489] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o FAILED: src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o /usr/bin/cmake -E __run_co_compile --launcher=/usr/bin/ccache --tidy="/usr/bin/clang-tidy-8;-warnings-as-errors=*" --source=../../src/wallet/scriptpubkeyman.cpp -- /usr/bin/clang++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -isystem /usr/include/jemalloc -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wshadow -Wshadow-field -Wrange-loop-analysis -Wredundant-decls -Wformat-security -Wredundant-move -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++14 -MD -MT src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o -MF src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o.d -o src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o -c ../../src/wallet/scriptpubkeyman.cpp /work/abc-ci-builds/build-clang-tidy/../../src/wallet/scriptpubkeyman.cpp:1609:71: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors] i, provider, scripts_temp, out_keys, &temp_cache)) ^ { 2732 warnings generated. Suppressed 2731 warnings (2731 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 1 warning treated as error [354/489] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o [355/489] Building CXX object src/seeder/CMakeFiles/seeder.dir/bitcoin.cpp.o [356/489] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o [357/489] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o [358/489] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o [359/489] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o [360/489] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o [361/489] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o [362/489] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o [363/489] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o [364/489] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o [365/489] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o [366/489] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o ninja: build stopped: subcommand failed. Build build-clang-tidy failed with exit code 1 |