Page MenuHomePhabricator
Differential D8438

test: add functional test for non-standard bare multisig txs
ClosedPublic
Actions

Authored by PiRK on Nov 17 2020, 15:32.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC34d484f0d9ea: test: add functional test for non-standard bare multisig txs
Summary

A transaction is rejected by the mempool with reason "bare-multisig" if any of
the outputs' scriptPubKey has bare multisig format (M <PubKey1> <PubKey2> ...
<PubKeyN> N OP_CHECKSIG) and bitcoind is started with "-permitbaremultisig=0".

This is a backport of Core PR17541

Test Plan

ninja && test/functional/test_runner.py mempool_accept

Diff Detail

Event Timeline

PiRK created this revision.Nov 17 2020, 15:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 17 2020, 15:32
PiRK requested review of this revision.Nov 17 2020, 15:32
teamcity edited the summary of this revision. (Show Details)Nov 17 2020, 15:32
Harbormaster completed remote builds in B14080: Diff 25822.Nov 17 2020, 15:41
Fabien requested changes to this revision.Nov 17 2020, 16:16
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/mempool_accept.py
308 ↗(On Diff #25822)

duplicated

This revision now requires changes to proceed.Nov 17 2020, 16:16
PiRK updated this revision to Diff 25830.Nov 18 2020, 06:57

remove duplicated code

Fabien accepted this revision.Nov 18 2020, 07:11
This revision is now accepted and ready to land.Nov 18 2020, 07:11
Harbormaster completed remote builds in B14086: Diff 25830.Nov 18 2020, 07:26
Closed by commit rABC34d484f0d9ea: test: add functional test for non-standard bare multisig txs (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhyNov 18 2020, 11:00
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC34d484f0d9ea: test: add functional test for non-standard bare multisig txs.

Revision Contents
Changeset List

PathSize
test/
functional/
17 lines

Diff 25830

View Options

test/functional/mempool_accept.py

Loading...