Page MenuHomePhabricator

Reorganise qa directory #9956 backport from bitcoin
AbandonedPublic

Authored by schancel on Dec 24 2017, 16:13.

Details

Reviewers
deadalnix
Mengerian
Yura
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

backport of this commits https://github.com/bitcoin/bitcoin/pull/9956/commits from bitcoin to bitcoin-abc

Test Plan
make check
test/functional/test-runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
com-9556
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1461
Build 1461: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Dec 24 2017, 16:13

Looks good. Please update the commit message to reference the commit hashes you're porting over.

test/util/buildenv.py
1 โ†—(On Diff #2238)

I don't think this file should be committed, see the comment on the test/util/buildenv.py.in file.

test/util/buildenv.py.in
2 โ†—(On Diff #2238)

I believe this is an inputfile to autogen.sh. There should be some configure.ac file changes associated that need to be included in this commit.

schancel requested changes to this revision.Dec 26 2017, 07:42
This revision now requires changes to proceed.Dec 26 2017, 07:42

add test/util/buildenv.py to .gitignore

schancel requested changes to this revision.Dec 29 2017, 22:25
schancel added inline comments.
test/util/buildenv.py
1

I see you added this to git ignore, but you didn't remove it from the commit yet. :)

test/util/buildenv.py.in
2

There should be a reference to this from another file in this commit. Configure takes this and makes buildenv.py

This revision now requires changes to proceed.Dec 29 2017, 22:25
schancel edited reviewers, added: Yura; removed: schancel.