Moving cashtab to web/ folder
AbandonedPublic
Actions

Authored by bytesofman on Nov 18 2020, 23:29.

Details

Reviewers

jasonbcox
deadalnix

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

Adds cashtab in current state to the web/ folder to begin tracking development in Phabricator

Test Plan

For now, this is a placeholder commit. Dockerfile and extract-cashtab.sh must be customized
depending on deployment plan.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

adding-cashtab

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14093
Build 28188: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-clang · build-debug
Build 28187: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 18 2020, 23:29

Owners added a reviewer: Restricted Owners Package.Nov 18 2020, 23:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 18 2020, 23:29

bytesofman requested review of this revision.Nov 18 2020, 23:29

Harbormaster completed remote builds in B14093: Diff 25850.Nov 18 2020, 23:41

I wonder what's the deal with "doing XXX" rather than "do XXX". Is there a reason? I've seen you and John do it and never anyone else I've worked with before.

You apparently have stacked some stuff here. IMO, you should start with a commit like this one, creating a place for the thing and then adds the different parts.

This revision now requires changes to proceed.Nov 18 2020, 23:44

Abandoning, will amend earlier diff