Differential D8465

net processing: Add support for getcfheaders
ClosedPublic
Actions

Authored by Fabien on Nov 19 2020, 15:13.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCa2ee2a50584a: net processing: Add support for getcfheaders

Summary

Support getcfheaders requests when -peerblockfilters is set.

Does not advertise compact filter support in version messages.

Backport of core PR19010.

Depends on D8464.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19010

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14109
Build 28220: Build Diff	build-diff · build-without-wallet · lint-circular-dependencies · build-clang-tidy · build-clang · build-debug
Build 28219: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 19 2020, 15:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 19 2020, 15:13

Fabien requested review of this revision.Nov 19 2020, 15:13

teamcity edited the summary of this revision. (Show Details)Nov 19 2020, 15:14

Harbormaster completed remote builds in B14109: Diff 25873.Nov 19 2020, 15:24

Fabien added a child revision: D8469: net processing: Add support for getcfilters.Nov 19 2020, 15:52

deadalnix accepted this revision.Nov 19 2020, 15:53

This revision is now accepted and ready to land.Nov 19 2020, 15:53

Closed by commit rABCa2ee2a50584a: net processing: Add support for getcfheaders (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyNov 19 2020, 17:05

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa2ee2a50584a: net processing: Add support for getcfheaders.

Fabien mentioned this in T589: BIP157 & BIP158 backports.Dec 23 2020, 09:48

Revision Contents
Changeset List

Path

Size

src/

index/

4 lines

115 lines

16 lines

21 lines

test/

functional/

p2p_blockfilters.py

53 lines

test_framework/

messages.py

56 lines

mininode.py

4 lines

Diff 25873

View Options

src/index/blockfilterindex.h

View Options

src/net_processing.cpp

View Options

src/protocol.h

View Options

src/protocol.cpp

View Options

test/functional/p2p_blockfilters.py

View Options

test/functional/test_framework/messages.py

View Options

test/functional/test_framework/mininode.py

net processing: Add support for getcfheadersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25873

src/index/blockfilterindex.h

src/net_processing.cpp

src/protocol.h

src/protocol.cpp

test/functional/p2p_blockfilters.py

test/functional/test_framework/messages.py

test/functional/test_framework/mininode.py

net processing: Add support for getcfheaders
ClosedPublic
Actions

Revision Contents
Changeset List