Differential D8467

Return error when no ScriptPubKeyMan is available for specified type
ClosedPublic
Actions

Authored by deadalnix on Nov 19 2020, 15:22.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABCf53059d18e7c: Return error when no ScriptPubKeyMan is available for specified type

Summary

When a CWallet doesn't have a ScriptPubKeyMan for the requested type
in GetNewDestination, give a meaningful error. Also handle this in
Qt which did not do anything with errors.

Backport of Core PR16528 [39/43] : https://github.com/bitcoin/bitcoin/pull/16528/commits/3c19fdd2a2fd5394fcfa75b2ba84ab2277cbdabf

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Nov 19 2020, 15:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 19 2020, 15:22

deadalnix requested review of this revision.Nov 19 2020, 15:22

teamcity edited the summary of this revision. (Show Details)Nov 19 2020, 15:22

Harbormaster completed remote builds in B14111: Diff 25875.Nov 19 2020, 15:35

jasonbcox accepted this revision.Nov 19 2020, 16:34

This revision is now accepted and ready to land.Nov 19 2020, 16:34

Closed by commit rABCf53059d18e7c: Return error when no ScriptPubKeyMan is available for specified type (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyNov 19 2020, 20:40

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCf53059d18e7c: Return error when no ScriptPubKeyMan is available for specified type.

Revision Contents
Changeset List

Path

Size

src/

qt/

receivecoinsdialog.cpp

44 lines

wallet/

wallet.cpp

3 lines

Diff 25894

View Options

src/qt/receivecoinsdialog.cpp