HomePhabricator

Return error when no ScriptPubKeyMan is available for specified type

Description

Return error when no ScriptPubKeyMan is available for specified type

Summary:
When a CWallet doesn't have a ScriptPubKeyMan for the requested type
in GetNewDestination, give a meaningful error. Also handle this in
Qt which did not do anything with errors.

Backport of Core PR16528 [39/43] : https://github.com/bitcoin/bitcoin/pull/16528/commits/3c19fdd2a2fd5394fcfa75b2ba84ab2277cbdabf

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D8467

Details

Provenance
Andrew Chow <achow101-github@achow101.com>Authored on Feb 14 2020, 02:06
deadalnixCommitted on Nov 19 2020, 20:40
deadalnixPushed on Nov 19 2020, 20:40
Reviewer
Restricted Project
Differential Revision
D8467: Return error when no ScriptPubKeyMan is available for specified type
Parents
rABCa58b36f37fc1: Correctly check for default wallet
Branches
Unknown
Tags
Unknown