Page MenuHomePhabricator

Adding a landing page for BCHA information
ClosedPublic

Authored by johnkuney on Nov 20 2020, 06:18.

Details

Reviewers
deadalnix
Mengerian
Group Reviewers
Restricted Project
Commits
rABCWEB016b151c8208: Adding a landing page for BCHA information
Summary

We need a landing page to hold the various information users might need about BCHA.
This is a very quick and basic version of that, but will continue to improve and expand as needed.

Test Plan

Review and iterate as needed

Diff Detail

Repository
rABCWEB Bitcoin ABC Website
Branch
bcha-page
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14137
Build 28273: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Nov 20 2020, 14:40
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
bcha.html
10 ↗(On Diff #25903)

?

This revision now requires changes to proceed.Nov 20 2020, 14:40
Mengerian requested changes to this revision.Nov 20 2020, 16:36
Mengerian added a subscriber: Mengerian.

Could you put a link in the banner, so that people can navigate to it from the main site?

I'll re-review the rest once the content is updated with the content from Christabel.

I tested it and it builds fine on my machine.

Adding Content updates based on Chrsitabels copy

-removed bcha logo
-updated copy and images

bcha.html
30 ↗(On Diff #25903)

This is the wrong text for the link.....

Also, the link doesn't seem to go to a wallet.

Let's just remove this one for now, until we get the correct name and link from Chris Troutner.

Remove incorrect wallet link

  • Removing the fullstack.cash link for now

OK, I think this is good as an initial MVP.

We can do some improvements like add more logos for the links, in later Diffs.

I built and tested it locally, worked fine.

deadalnix requested changes to this revision.Nov 20 2020, 20:21
This revision now requires changes to proceed.Nov 20 2020, 20:21
This revision is now accepted and ready to land.Nov 20 2020, 20:21