Page MenuHomePhabricator

[buildbot] Fix getcommitpaths result type
ClosedPublic

Authored by jasonbcox on Nov 20 2020, 18:56.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf6664ddd8ad6: [buildbot] Fix getcommitpaths result type
Summary

Despite the Conduit testing dashboard returning a dictionary, actually
calling the endpoint directly with curl gives a list. This may have something to
do with the way that Conduit is written in PHP and printing the list out with
integer indexing, which is the default in PHP.

This fixes builds not triggering correctly on revisions.

Test Plan

pytest

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rod-list-fix
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14134
Build 28269: Build Diff
Build 28268: arc lint + arc unit