Page MenuHomePhabricator

Only run node-related builds on diffs where the node software has changed
ClosedPublic

Authored by jasonbcox on Fri, Nov 20, 20:02.

Details

Summary

This ensures changes to the docs, websites, and other infra do not
kick off a bunch of tests that only pertain to the node software. While these
heuristics may not be perfect, any breaking change will still be caught by
CI after changes are landed.

Test Plan

There is currently no good way to test this, so just read it
carefully for now.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien requested changes to this revision.Sat, Nov 21, 09:45
Fabien added a subscriber: Fabien.

Just make a template

node:
  runOnDiffRegex:
      - cmake/
      - src/
      - test/

and use it everywhere

This revision now requires changes to proceed.Sat, Nov 21, 09:45

Used a template where it makes sense. For the others, it doesn't make sense to run them when
only changes to the functional tests are made.

Use the template on the clang builds. Even though changes to functional tests only will be a false positive,
catching changes to /cmake are important. Functional test only changes are not super common, so we
can live with this tradeoff to reduce maintenance overhead and reduce false negatives.

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
This revision is now accepted and ready to land.Mon, Nov 23, 19:34