HomePhabricator

fix assert crash when specified change output spend size is unknown

Description

fix assert crash when specified change output spend size is unknown

Summary:
Remove stale comment in CalculateMaximumSignedInputSize

CreateTransaction: Assume minimum p2sh-p2wpkh spend size for unknown change

This is a backport of Core PR14380

Test Plan:

ninja check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8500

Details

Provenance
Gregory Sanders <gsanders87@gmail.com>Authored on Oct 3 2018, 05:40
deadalnixCommitted on Nov 23 2020, 17:48
deadalnixPushed on Nov 23 2020, 17:48
Reviewer
Restricted Project
Differential Revision
D8500: fix assert crash when specified change output spend size is unknown
Parents
rABCa450bcafd954: [refactoring] eliminate Boost::Optional for std::optional
Branches
Unknown
Tags
Unknown