Page MenuHomePhabricator

fix assert crash when specified change output spend size is unknown
ClosedPublic

Authored by deadalnix on Nov 23 2020, 15:43.

Details

Summary

Remove stale comment in CalculateMaximumSignedInputSize

CreateTransaction: Assume minimum p2sh-p2wpkh spend size for unknown change

This is a backport of Core PR14380

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/test/wallet_tests.cpp
662 ↗(On Diff #25968)

inner-script => script

This revision is now accepted and ready to land.Nov 23 2020, 16:21