Page MenuHomePhabricator
Differential D8500

fix assert crash when specified change output spend size is unknown
ClosedPublic
Actions

Authored by deadalnix on Nov 23 2020, 15:43.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC9e07ed780cf2: fix assert crash when specified change output spend size is unknown
Summary

Remove stale comment in CalculateMaximumSignedInputSize

CreateTransaction: Assume minimum p2sh-p2wpkh spend size for unknown change

This is a backport of Core PR14380

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Nov 23 2020, 15:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 23 2020, 15:43
deadalnix requested review of this revision.Nov 23 2020, 15:43
teamcity edited the summary of this revision. (Show Details)Nov 23 2020, 15:44
Harbormaster completed remote builds in B14167: Diff 25968.Nov 23 2020, 15:55
Fabien accepted this revision.Nov 23 2020, 16:21
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/test/wallet_tests.cpp
662 ↗(On Diff #25968)

inner-script => script

This revision is now accepted and ready to land.Nov 23 2020, 16:21
Closed by commit rABC9e07ed780cf2: fix assert crash when specified change output spend size is unknown (authored by Gregory Sanders <gsanders87@gmail.com>, committed by deadalnix). · Explain WhyNov 23 2020, 17:49
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC9e07ed780cf2: fix assert crash when specified change output spend size is unknown.

Revision Contents
Changeset List

PathSize
src/
wallet/
test/
37 lines
2 lines
16 lines
test/
functional/
10 lines

Diff 25976

View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

test/functional/rpc_psbt.py

Loading...