Differential D8498

tests: Add RPCOverloadWrapper which overloads some disabled RPCs
ClosedPublic
Actions

Authored by deadalnix on Nov 22 2020, 17:08.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCf24e79e45b2a: tests: Add RPCOverloadWrapper which overloads some disabled RPCs

Summary

RPCOverloadWrapper overloads some deprecated or disabled RPCs with
an implementation using other RPCs to avoid having a ton of code churn
around replacing those RPCs.

Backport of Core PR16528 [42/43] : https://github.com/bitcoin/bitcoin/pull/16528/commits/869f7ab30aeb4d7fbd563c535b55467a8a0430cf

Depends on D8487

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr16528-42

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14163
Build 28319: Build Diff	build-without-wallet · build-debug · build-diff · lint-circular-dependencies · build-clang-tidy · build-clang
Build 28318: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 22 2020, 17:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 22 2020, 17:08

deadalnix requested review of this revision.Nov 22 2020, 17:08

teamcity edited the summary of this revision. (Show Details)Nov 22 2020, 17:08

Harbormaster completed remote builds in B14163: Diff 25959.Nov 22 2020, 17:20

Fabien accepted this revision.Nov 23 2020, 08:35

This revision is now accepted and ready to land.Nov 23 2020, 08:35

Closed by commit rABCf24e79e45b2a: tests: Add RPCOverloadWrapper which overloads some disabled RPCs (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyNov 23 2020, 14:32

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCf24e79e45b2a: tests: Add RPCOverloadWrapper which overloads some disabled RPCs.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

116 lines

wallet_descriptor.py

18 lines

Diff 25959

test/functional/test_framework/test_node.py

Loading...

test/functional/wallet_descriptor.py

Loading...