Use absolute paths for images on BCHA page
ClosedPublic
Actions

Authored by jasonbcox on Nov 23 2020, 17:20.

Details

Reviewers

Mengerian

Group Reviewers

Restricted Project

Commits

rABCWEBf881e24b8931: Use absolute paths for images on BCHA page

Summary

Relative paths for static content tend to be fragile.

Test Plan

make serve
Navigate to http://127.0.0.1:4000/bcha/ and verify all images load as expected.

Diff Detail

Repository

rABCWEB Bitcoin ABC Website

Branch

abs-imgs

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 14170
Build 28331: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Nov 23 2020, 17:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 23 2020, 17:20

jasonbcox requested review of this revision.Nov 23 2020, 17:20

Harbormaster completed remote builds in B14170: Diff 25971.Nov 23 2020, 17:20

Tested locally, looks good

This revision is now accepted and ready to land.Nov 23 2020, 18:07

Closed by commit rABCWEBf881e24b8931: Use absolute paths for images on BCHA page (authored by jasonbcox). · Explain WhyNov 23 2020, 18:09

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCWEBf881e24b8931: Use absolute paths for images on BCHA page.

Revision Contents
Changeset List

Path

Size

bcha.html

32 lines

Diff 25971

View Options

Use absolute paths for images on BCHA pageClosedPublicActions